flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6876) The comment of DataStream#assignTimestampsAndWatermarks is incorrect
Date Fri, 09 Jun 2017 04:05:18 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043888#comment-16043888
] 

ASF GitHub Bot commented on FLINK-6876:
---------------------------------------

GitHub user dianfu opened a pull request:

    https://github.com/apache/flink/pull/4092

    [FLINK-6876] [streaming] Correct the comments of DataStream#assignTimestampsAndWatermarks

    This PR corrects the comments of DataStream#assignTimestampsAndWatermarks.
    
    
    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dianfu/flink FLINK-6876

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4092.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4092
    
----
commit 40d3c2ef81d3e1fcfc35fd2302835fa5aa6aec5a
Author: 付典 <fudian.fd@alibaba-inc.com>
Date:   2017-06-09T03:58:39Z

    Correct the comments of DataStream#assignTimestampsAndWatermarks

----


> The comment of DataStream#assignTimestampsAndWatermarks is incorrect
> --------------------------------------------------------------------
>
>                 Key: FLINK-6876
>                 URL: https://issues.apache.org/jira/browse/FLINK-6876
>             Project: Flink
>          Issue Type: Bug
>          Components: DataStream API
>            Reporter: Dian Fu
>            Priority: Minor
>
> The comment of DataStream#assignTimestampsAndWatermarks is incorrect, we should correct
it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message