flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "sunjincheng (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6859) StateCleaningCountTrigger should not delete timer
Date Wed, 07 Jun 2017 10:00:24 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040629#comment-16040629
] 

sunjincheng commented on FLINK-6859:
------------------------------------

Get set of registered timers by namespace. And traverse the timer queue to delete the timers.
is really expensive operation. I'll remove it .

> StateCleaningCountTrigger should not delete timer
> -------------------------------------------------
>
>                 Key: FLINK-6859
>                 URL: https://issues.apache.org/jira/browse/FLINK-6859
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.3.0
>            Reporter: Fabian Hueske
>
> The {{StateCleaningCountTrigger}} which is used to clean-up inactive state should not
delete timers, i.e.. not call {{deleteProcessingTimeTimer()}}.
> This is an expensive operation.
> We should rather fire the timer and check if we need to clean the state or not.
> What do you think [~sunjincheng121]?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message