flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6841) using TableSourceTable for both Stream and Batch OR remove useless import
Date Wed, 21 Jun 2017 14:33:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057612#comment-16057612
] 

ASF GitHub Bot commented on FLINK-6841:
---------------------------------------

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/4061
  
    Hi @sunjincheng121! I left a comment on the JIRA issue. Short summary: I don't think this
PR is a significant improvement. I'd rather keep it as it is unless you have a good argument
to convince me.
    
    Thank you, Fabian


> using TableSourceTable for both Stream and Batch OR remove useless import
> -------------------------------------------------------------------------
>
>                 Key: FLINK-6841
>                 URL: https://issues.apache.org/jira/browse/FLINK-6841
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>
> 1. {{StreamTableSourceTable}} exist useless import of {{TableException}}
> 2. {{StreamTableSourceTable}} only override {{getRowType}} of  {{FlinkTable}}, I think
we can override the method in {{TableSourceTable}}, If so we can using {{TableSourceTable}}
for both {{Stream}} and {{Batch}}.
> What do you think? [~fhueske] [~twalthr]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message