flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (FLINK-6493) Ineffective null check in RegisteredOperatorBackendStateMetaInfo#equals()
Date Sun, 11 Jun 2017 22:21:18 GMT

     [ https://issues.apache.org/jira/browse/FLINK-6493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ted Yu updated FLINK-6493:
--------------------------
    Description: 
{code}
        && ((partitionStateSerializer == null && ((Snapshot) obj).getPartitionStateSerializer()
== null)
          || partitionStateSerializer.equals(((Snapshot) obj).getPartitionStateSerializer()))
        && ((partitionStateSerializerConfigSnapshot == null && ((Snapshot)
obj).getPartitionStateSerializerConfigSnapshot() == null)
          || partitionStateSerializerConfigSnapshot.equals(((Snapshot) obj).getPartitionStateSerializerConfigSnapshot()));
{code}
The null check for partitionStateSerializer / partitionStateSerializerConfigSnapshot is in
combination with another clause.

This may lead to NPE in the partitionStateSerializer.equals() call.

  was:
{code}
        && ((partitionStateSerializer == null && ((Snapshot) obj).getPartitionStateSerializer()
== null)
          || partitionStateSerializer.equals(((Snapshot) obj).getPartitionStateSerializer()))
        && ((partitionStateSerializerConfigSnapshot == null && ((Snapshot)
obj).getPartitionStateSerializerConfigSnapshot() == null)
          || partitionStateSerializerConfigSnapshot.equals(((Snapshot) obj).getPartitionStateSerializerConfigSnapshot()));
{code}

The null check for partitionStateSerializer / partitionStateSerializerConfigSnapshot is in
combination with another clause.

This may lead to NPE in the partitionStateSerializer.equals() call.


> Ineffective null check in RegisteredOperatorBackendStateMetaInfo#equals()
> -------------------------------------------------------------------------
>
>                 Key: FLINK-6493
>                 URL: https://issues.apache.org/jira/browse/FLINK-6493
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing
>            Reporter: Ted Yu
>            Priority: Minor
>
> {code}
>         && ((partitionStateSerializer == null && ((Snapshot) obj).getPartitionStateSerializer()
== null)
>           || partitionStateSerializer.equals(((Snapshot) obj).getPartitionStateSerializer()))
>         && ((partitionStateSerializerConfigSnapshot == null && ((Snapshot)
obj).getPartitionStateSerializerConfigSnapshot() == null)
>           || partitionStateSerializerConfigSnapshot.equals(((Snapshot) obj).getPartitionStateSerializerConfigSnapshot()));
> {code}
> The null check for partitionStateSerializer / partitionStateSerializerConfigSnapshot
is in combination with another clause.
> This may lead to NPE in the partitionStateSerializer.equals() call.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message