flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6008) collection of BlobServer improvements
Date Wed, 28 Jun 2017 16:07:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066780#comment-16066780
] 

ASF GitHub Bot commented on FLINK-6008:
---------------------------------------

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4146#discussion_r124584383
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobClient.java ---
    @@ -593,9 +594,7 @@ private void sendPutHeader(OutputStream outputStream, JobID jobID,
String key) t
     	 *         the BLOB server or if the BLOB server cannot delete the file
     	 */
     	public void delete(BlobKey key) throws IOException {
    -		if (key == null) {
    -			throw new IllegalArgumentException("BLOB key must not be null");
    -		}
    +		checkArgument(key != null, "BLOB key must not be null.");
    --- End diff --
    
    unfortunately, `checkNotNull` throws a `NullPointerException` instead and I did not want
to change that here


> collection of BlobServer improvements
> -------------------------------------
>
>                 Key: FLINK-6008
>                 URL: https://issues.apache.org/jira/browse/FLINK-6008
>             Project: Flink
>          Issue Type: Improvement
>          Components: Network
>    Affects Versions: 1.3.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>
> The following things should be improved around the BlobServer/BlobCache:
> * update config uptions with non-deprecated ones, e.g. {{high-availability.cluster-id}}
and {{high-availability.storageDir}}
> * promote {{BlobStore#deleteAll(JobID)}} to the {{BlobService}}
> * extend the {{BlobService}} to work with {{NAME_ADDRESSABLE}} blobs (prepares FLINK-4399]
> * remove {{NAME_ADDRESSABLE}} blobs after job/task termination
> * do not fail the {{BlobServer}} when a delete operation fails
> * code style, like using {{Preconditions.checkArgument}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message