flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3889: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...
Date Fri, 30 Jun 2017 15:16:40 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3889#discussion_r125058559
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/aggregate/TimeSortProcessFunctionTest.scala
---
    @@ -122,6 +130,11 @@ class TimeSortProcessFunctionTest{
           Row.of(1: JInt, 12L: JLong, 1: JInt, "aaa", 11L: JLong),true), 4))
         expectedOutput.add(new StreamRecord(new CRow(
           Row.of(1: JInt, 12L: JLong, 0: JInt, "aaa", 11L: JLong),true), 4))
    +    
    +    expectedOutput.add(new StreamRecord(new CRow(
    +      Row.of(1: JInt, 1L: JLong, 0: JInt, "aaa", 11L: JLong),true), 1006))
    +    expectedOutput.add(new StreamRecord(new CRow(
    +      Row.of(1: JInt, 2L: JLong, 0: JInt, "aaa", 11L: JLong),true), 1006))
           
         TestHarnessUtil.assertOutputEqualsSorted("Output was not correct.",
    --- End diff --
    
    The test should check that the ProcessFunction emit the rows in the correct order. `assertOutputEqualsSorted`
sorts the result and expected data before comparing them. We have to use `assertOutputEquals`
instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message