flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #4105: [FLINK-6888] [table] Can not determine TypeInforma...
Date Wed, 28 Jun 2017 16:20:20 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4105#discussion_r124578206
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
    @@ -320,12 +348,20 @@ object UserDefinedFunctionUtils {
         } else if(extractedType != null) {
           extractedType
         } else {
    -      TypeExtractor
    +      try {
    +        TypeExtractor
    --- End diff --
    
    The fallback type extraction of the accumulator type is different now. Before, we created
an accumulator instance and called `TypeInformation.of(Any)`. Now, we try to extract it from
the generics of the UDAGG.
    
    @twalthr, does this method work as reliable as `TypeInformation.of(Any)`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message