flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #4146: [FLINK-6008][blob] collection of BlobServer improv...
Date Wed, 28 Jun 2017 16:09:36 GMT
Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4146#discussion_r124585333
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobUtils.java ---
    @@ -227,7 +227,7 @@ static File getStorageLocation(File storageDir, JobID jobID, String
key) {
     	private static File getJobDirectory(File storageDir, JobID jobID) {
     		final File jobDirectory = new File(storageDir, JOB_DIR_PREFIX + jobID.toString());
     
    -		if (!jobDirectory.exists() && !jobDirectory.mkdirs()) {
    --- End diff --
    
    the new way is thread-safe - imagine a directory being concurrently created after another
thread has failed the `exists()` part - not sure we actually fix a bug nowadays since the
use may be guarded...so this is probably more of a "just-in-case" thing or if usage patterns
change


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message