flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #4146: [FLINK-6008][blob] collection of BlobServer improv...
Date Wed, 28 Jun 2017 15:20:32 GMT
Github user pnowojski commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobUtils.java ---
    @@ -227,7 +227,7 @@ static File getStorageLocation(File storageDir, JobID jobID, String
key) {
     	private static File getJobDirectory(File storageDir, JobID jobID) {
     		final File jobDirectory = new File(storageDir, JOB_DIR_PREFIX + jobID.toString());
    -		if (!jobDirectory.exists() && !jobDirectory.mkdirs()) {
    --- End diff --
    Why did you change the order of those operations? Is that fix for something? If so could
you add explanation to the commit message what's going on here?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message