flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wuchong <...@git.apache.org>
Subject [GitHub] flink pull request #4200: [FLINK-7014] Expose isDeterministic interface to S...
Date Wed, 28 Jun 2017 10:34:40 GMT
Github user wuchong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4200#discussion_r124506864
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/ExpressionReductionTest.scala
---
    @@ -458,4 +459,52 @@ class ExpressionReductionTest extends TableTestBase {
         util.verifySql(sqlQuery, expected)
       }
     
    +  // todo this NPE is caused by Calcite, it shall pass when [CALCITE-1860] is fixed
    +  @Ignore
    +  @Test(expected = classOf[NullPointerException])
    --- End diff --
    
    Yes, the expected test result should not throw exception. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message