flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhenzhongxu <...@git.apache.org>
Subject [GitHub] flink issue #4187: [FLINK-6998][Kafka Connector] Add kafka offset commit met...
Date Tue, 27 Jun 2017 22:43:06 GMT
Github user zhenzhongxu commented on the issue:

    **Regarding the metric naming:**
    Any suggestions on naming conventions for these flink specific metrics? How do you like
'kafkaconnector-commits-succeeded' (component-metric-name) as an example? I personally like
hyphen seperators better than camel case for metric names. 
    I'll not include the other proposed metric in this PR just for the sake of simplicity.
I also have some opinions on "offset lag" metric, I think this particular metric is more useful
when some external entity 
    perform the monitoring (difference of committed offset vs log head), especially in failure
    **Regarding the implementation:**
    Thanks for the feedback. I'll explore the more proper implementation suggested, I'll get
back to you with a solution or question.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message