flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dbrinegar <...@git.apache.org>
Subject [GitHub] flink pull request #4188: [FLINK-7009] dogstatsd mode in statds reporter
Date Tue, 27 Jun 2017 18:51:42 GMT
Github user dbrinegar commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4188#discussion_r124363952
  
    --- Diff: flink-metrics/flink-metrics-statsd/src/main/java/org/apache/flink/metrics/statsd/StatsDReporter.java
---
    @@ -90,6 +109,45 @@ public void close() {
     
     	// ------------------------------------------------------------------------
     
    +	/**
    +	 * Removes leading and trailing angle brackets.
    +	 */
    +	private String stripBrackets(String str) {
    +		return str.substring(1, str.length() - 1);
    +	}
    +
    +	@Override
    +	public void notifyOfAddedMetric(Metric metric, String metricName, MetricGroup group)
{
    +		if (dogstatsdMode) {
    +			// memoize dogstatsd tag section: "|#tag:val,tag:val,tag:val"
    +			StringBuilder statsdTagLine = new StringBuilder();
    +			Map<String, String> orderedTags = new TreeMap<>(group.getAllVariables());
    --- End diff --
    
    sorry!  this was the beginning of looking at a more efficient tag table, as many entries
are duplicates, but I'll take out since we're going to put the tag line in the metric object


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message