flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kl0u <...@git.apache.org>
Subject [GitHub] flink pull request #4143: [FLINK-6418][cep] Support for dynamic state change...
Date Fri, 23 Jun 2017 10:08:57 GMT
Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4143#discussion_r123715389
  
    --- Diff: docs/dev/libs/cep.md ---
    @@ -334,6 +334,20 @@ pattern.where(event => ... /* some condition */).or(event =>
... /* or condition
     </div>
     </div>
     
    +
    +**Stop condition:** In case of kleene operators (`oneOrMore()` and `oneOrMore().optional()`)
you can
    +also specify a stop condition, e.g. accept events with value larger than 5 until the
sum of values is smaller than 50.
    --- End diff --
    
    In general, I would not use the "kleene" term, as we do not use it throughout the rest
of the docs.
    You can say sth like "looping" or simply oneOrMore.
    In addition, it would also be more consistent to not use "operator" but "pattern". In
the docs we have "pattern sequences" composed of "patterns" so we should stick to that.
    
    So "Kleene Operator" -> "looping pattern" or "oneOrMore pattern"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message