flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dawidwys <...@git.apache.org>
Subject [GitHub] flink pull request #4145: [FLINK-6938][FLINK-6939] [cep] Not store Iterative...
Date Tue, 20 Jun 2017 14:19:18 GMT
Github user dawidwys commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java
    @@ -126,6 +129,7 @@ public AbstractKeyedCEPPatternOperator(
     		this.isProcessingTime = Preconditions.checkNotNull(isProcessingTime);
     		this.keySerializer = Preconditions.checkNotNull(keySerializer);
     		this.nfaFactory = Preconditions.checkNotNull(nfaFactory);
    +		this.conditionRegistry = nfaFactory.createNFA().getConditionRegistry();
    --- End diff --
    Maybe let's access conditionRegistry through nfaFactory rather than NFA itselfs?
    Anyway I think we should think of removing one layer in the `NFACompiler.java`, but I
will create a seperate JIRA for this.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message