flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #4034: [FLINK-6786] [metrics] Deduplicate QueryScopeIntoT...
Date Tue, 20 Jun 2017 09:31:01 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4034#discussion_r122925221
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/metrics/dump/QueryScopeInfoTest.java
---
    @@ -20,58 +20,140 @@
     
     import org.junit.Test;
     
    -import static org.apache.flink.runtime.metrics.dump.QueryScopeInfo.INFO_CATEGORY_JM;
    --- End diff --
    
    Whether to use static imports or not is currently rather undefined in Flink.
    
    In this case i would remove the static import to make it very clear in the test that we're
comparing to a constant that is defined outside the test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message