flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #3951: [FLINK-6461] Replace usages of deprecated web port...
Date Mon, 19 Jun 2017 13:12:27 GMT
Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3951#discussion_r122701964
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
    @@ -173,7 +173,7 @@ class JobManager(
        * to run in the actor system of the associated job manager.
        */
       val webMonitorPort : Int = flinkConfiguration.getInteger(
    -    ConfigConstants.JOB_MANAGER_WEB_PORT_KEY, -1)
    +    JobManagerOptions.WEB_PORT.key(), -1)
    --- End diff --
    
    I am not sure, but why don't you use `flinkConfiguration.getInteger(JobManagerOptions.WEB_PORT)`?
It would have different semantics (it would return `8081` instead of `-1` in case of missing
value).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message