flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wuchong <...@git.apache.org>
Subject [GitHub] flink pull request #4102: [FLINK-6886][table]Fix Timestamp field can not be ...
Date Tue, 13 Jun 2017 14:26:31 GMT
Github user wuchong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4102#discussion_r121694007
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
    @@ -715,15 +715,8 @@ abstract class TableEnvironment(val config: TableConfig) {
           functionName: String):
         GeneratedFunction[MapFunction[Row, OUT], OUT] = {
     
    -    // validate that at least the field types of physical and logical type match
    -    // we do that here to make sure that plan translation was correct
    -    if (schema.physicalTypeInfo != inputTypeInfo) {
    -      throw TableException("The field types of physical and logical row types do not
match." +
    -        "This is a bug and should not happen. Please file an issue.")
    -    }
    -
    -    val fieldTypes = schema.physicalFieldTypeInfo
    -    val fieldNames = schema.physicalFieldNames
    +    val fieldTypes = schema.logicalFieldTypeInfo
    +    val fieldNames = schema.logicalFieldNames
    --- End diff --
    
    I'm not sure about this change. The physical and logical type check is to make sure all
the time indicators are translated. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message