flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wuchong <...@git.apache.org>
Subject [GitHub] flink pull request #4105: [FLINK-6888] [table] Can not determine TypeInforma...
Date Mon, 12 Jun 2017 08:35:37 GMT
Github user wuchong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4105#discussion_r121335993
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
    @@ -329,6 +337,41 @@ object UserDefinedFunctionUtils {
         }
       }
     
    +
    +  /**
    +    * Internal method of AggregateFunction#getAccumulatorType() that does some pre-checking
    +    * and uses [[TypeExtractor]] as default return type inference.
    +    */
    +  def getAccumulatorTypeOfAggregateFunction(
    +    aggregateFunction: AggregateFunction[_, _],
    --- End diff --
    
    Good idea. I like it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message