flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wuchong <...@git.apache.org>
Subject [GitHub] flink pull request #4105: [FLINK-6888] [table] Can not determine TypeInforma...
Date Mon, 12 Jun 2017 08:33:40 GMT
Github user wuchong commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/AggSqlFunction.scala
    @@ -37,24 +36,26 @@ import org.apache.flink.table.functions.utils.UserDefinedFunctionUtils._
       * @param name function name (used by SQL parser)
       * @param aggregateFunction aggregate function to be called
       * @param returnType the type information of returned value
    +  * @param accType the type information of the accumulator
       * @param typeFactory type factory for converting Flink's between Calcite's types
     class AggSqlFunction(
         name: String,
         aggregateFunction: AggregateFunction[_, _],
    -    returnType: TypeInformation[_],
    +    val returnType: TypeInformation[_],
    +    val accType: TypeInformation[_],
         typeFactory: FlinkTypeFactory,
         requiresOver: Boolean)
    -  extends SqlUserDefinedAggFunction(
    +  extends SqlAggFunction(
    --- End diff --
    Sorry, I didn't notice the copied `SqlUserDefinedAggFunction` from Calcite. I did these
change because the constructor of Calcite `SqlUserDefinedAggFunction` doesn't match the calling
with additional `requiresOver`. 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message