flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #4039: [FLINK-6783] Changed passing index of type argumen...
Date Tue, 06 Jun 2017 15:55:43 GMT
Github user twalthr commented on a diff in the pull request:

    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/CoGroupedStreams.java
    @@ -231,14 +231,18 @@ protected WithWindow(DataStream<T1> input1,
     		public <T> DataStream<T> apply(CoGroupFunction<T1, T2, T> function)
     			TypeInformation<T> resultType = TypeExtractor.getBinaryOperatorReturnType(
    -					function,
    -					CoGroupFunction.class,
    -					true,
    -					true,
    -					input1.getType(),
    -					input2.getType(),
    -					"CoGroup",
    -					false);
    +				function,
    --- End diff --
    We could use `TypeExtractor#getCoGroupReturnTypes()` and save some duplicate code, but
I'm also fine with this.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message