flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sunjincheng121 <...@git.apache.org>
Subject [GitHub] flink pull request #4055: [FLINK-6817] [table] Fix NPE when preceding is not...
Date Sun, 04 Jun 2017 23:38:47 GMT
Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4055#discussion_r120023997
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/windows.scala
---
    @@ -127,3 +127,21 @@ class PartitionedOver(private val partitionByExpr: Array[Expression])
{
         new OverWindowWithOrderBy(partitionByExpr, orderByExpr)
       }
     }
    +
    +
    +class OverWindowWithOrderBy(
    +  private val partitionByExpr: Array[Expression],
    --- End diff --
    
    Suggest that change `partitionByExpr` to `partitionBy` for keep param name consistent
with SCALA. What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message