Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Tue, 9 May 2017 08:19:04 +0000 (UTC)
From: "Tzu-Li (Gordon) Tai (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13070330.1494317874000.161685.1494317944037@Atlassian.JIRA>
In-Reply-To: <JIRA.13070330.1494317874000@Atlassian.JIRA>
References: <JIRA.13070330.1494317874000@Atlassian.JIRA> <JIRA.13070330.1494317874426@jira-lw-us.apache.org>
Subject: [jira] [Updated] (FLINK-6503) Refactor KinesisDataFetcher to
 separate concerns for shard discovery
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 09 May 2017 08:19:08 -0000


     [ https://issues.apache.org/jira/browse/FLINK-6503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tzu-Li (Gordon) Tai updated FLINK-6503:
---------------------------------------
    Description: 
Currently, shard discovery is done within the {{KinesisDataFetcher}} 's loop. I propose to extract that from the fetcher and encapsulate that in a separate class to separate concerns.

As can be seen in https://github.com/apache/flink/pull/3001/files#diff-0b702244caed9a73b7b3e1dc8a9cbaebR461, one downside if we do not do this refactor is apparent when adding rescalability of the Kinesis consumer. That required shards lookup operations prioir to running the fetcher, which resulted in the need to expose shard fetching logic external to the `KinesisDataFetcher`. This should be properly done be separating concerns of shard discovery from the fetcher.

  was:
Currently, shard discovery is done within the `KinesisDataFetcher`'s loop. I propose to extract that from the fetcher and encapsulate that in a separate class to separate concerns.

As can be seen in https://github.com/apache/flink/pull/3001/files#diff-0b702244caed9a73b7b3e1dc8a9cbaebR461, one downside if we do not do this refactor is apparent when adding rescalability of the Kinesis consumer. That required shards lookup operations prioir to running the fetcher, which resulted in the need to expose shard fetching logic external to the `KinesisDataFetcher`. This should be properly done be separating concerns of shard discovery from the fetcher.


> Refactor KinesisDataFetcher to separate concerns for shard discovery
> --------------------------------------------------------------------
>
>                 Key: FLINK-6503
>                 URL: https://issues.apache.org/jira/browse/FLINK-6503
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kinesis Connector
>            Reporter: Tzu-Li (Gordon) Tai
>
> Currently, shard discovery is done within the {{KinesisDataFetcher}} 's loop. I propose to extract that from the fetcher and encapsulate that in a separate class to separate concerns.
> As can be seen in https://github.com/apache/flink/pull/3001/files#diff-0b702244caed9a73b7b3e1dc8a9cbaebR461, one downside if we do not do this refactor is apparent when adding rescalability of the Kinesis consumer. That required shards lookup operations prioir to running the fetcher, which resulted in the need to expose shard fetching logic external to the `KinesisDataFetcher`. This should be properly done be separating concerns of shard discovery from the fetcher.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)