Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Fri, 12 May 2017 16:41:04 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13060630.1490952900000.198745.1494607264777@Atlassian.JIRA>
In-Reply-To: <JIRA.13060630.1490952900000@Atlassian.JIRA>
References: <JIRA.13060630.1490952900000@Atlassian.JIRA> <JIRA.13060630.1490952900993@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-6232) Support proctime inner equi-join
 between two streams in the SQL API
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 12 May 2017 16:41:10 -0000


    [ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008354#comment-16008354 ] 

ASF GitHub Bot commented on FLINK-6232:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3715#discussion_r116269180
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamJoin.scala ---
    @@ -159,9 +172,9 @@ class DataStreamJoin(
         val procInnerJoinFunc = new ProcTimeInnerJoin(
           leftStreamWindowSize,
           rightStreamWindowSize,
    -      leftDataStream.getType,
    -      rightDataStream.getType,
    -      filterFunction)
    +      leftDataStream.getType.asInstanceOf[CRowTypeInfo].rowType,
    +      rightDataStream.getType.asInstanceOf[CRowTypeInfo].rowType,
    --- End diff --
    
    can be `rightSchema.physicalTypeInfo`


> Support proctime inner equi-join between two streams in the SQL API
> -------------------------------------------------------------------
>
>                 Key: FLINK-6232
>                 URL: https://issues.apache.org/jira/browse/FLINK-6232
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: hongyuhong
>            Assignee: hongyuhong
>
> The goal of this issue is to add support for inner equi-join on proc time streams to the SQL interface.
> Queries similar to the following should be supported:
> {code}
> SELECT o.proctime, o.productId, o.orderId, s.proctime AS shipTime 
> FROM Orders AS o 
> JOIN Shipments AS s 
> ON o.orderId = s.orderId 
> AND o.proctime BETWEEN s.proctime AND s.proctime + INTERVAL '1' HOUR;
> {code}
> The following restrictions should initially apply:
> * The join hint only support inner join
> * The ON clause should include equi-join condition
> * The time-condition {{o.proctime BETWEEN s.proctime AND s.proctime + INTERVAL '1' HOUR}} only can use proctime that is a system attribute, the time condition only support bounded time range like {{o.proctime BETWEEN s.proctime - INTERVAL '1' HOUR AND s.proctime + INTERVAL '1' HOUR}}, not support unbounded like {{o.proctime > s.protime}},  and  should include both two stream's proctime attribute, {{o.proctime between proctime() and proctime() + 1}} should also not be supported.
> This issue includes:
> * Design of the DataStream operator to deal with stream join
> * Translation from Calcite's RelNode representation (LogicalJoin). 


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)