Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: fhueske <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-3673-flink@git.apache.org>
In-Reply-To: <git-pr-3673-flink@git.apache.org>
Subject: [GitHub] flink pull request #3673: [FLINK-5256] Extend DataSetSingleRowJoin to suppor...
Content-Type: text/plain
Message-Id: <20170512150225.896A2DFBAB@git1-us-west.apache.org>
Date: Fri, 12 May 2017 15:02:25 +0000 (UTC)
archived-at: Fri, 12 May 2017 15:02:32 -0000

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3673#discussion_r116250994
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/logical/FlinkLogicalJoin.scala ---
    @@ -77,7 +77,9 @@ private class FlinkLogicalJoinConverter
         val join: LogicalJoin = call.rel(0).asInstanceOf[LogicalJoin]
         val joinInfo = join.analyzeCondition
     
    -    hasEqualityPredicates(join, joinInfo) || isSingleRowInnerJoin(join)
    +    (hasEqualityPredicates(join, joinInfo)
    +      || isSingleRowInnerJoin(join)
    +      || isOuterJoinWithSingleRowAtOuterSide(join, joinInfo))
    --- End diff --
    
    We need here the same condition as in `DataSetSingleRowJoinRule.matches()`:
    
    ```
    join.getJoinType match {
      case JoinRelType.INNER if isSingleRow(join.getRight) || isSingleRow(join.getLeft) => true
      case JoinRelType.LEFT if isSingleRow(join.getRight) => true
      case JoinRelType.RIGHT if isSingleRow(join.getLeft) => true
     case _ => false
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---