Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: sunjincheng121 <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-3863-flink@git.apache.org>
In-Reply-To: <git-pr-3863-flink@git.apache.org>
Subject: [GitHub] flink pull request #3863: [FLINK-6491][talbe]Add QueryConfig to specify stat...
Content-Type: text/plain
Message-Id: <20170511054650.25275DFE61@git1-us-west.apache.org>
Date: Thu, 11 May 2017 05:46:50 +0000 (UTC)
archived-at: Thu, 11 May 2017 05:46:54 -0000

Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3863#discussion_r115908788
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala ---
    @@ -239,6 +248,7 @@ class DataStreamOverAggregate(
       }
     
       def createBoundedAndCurrentRowOverWindow(
    --- End diff --
    
    I do not think we need add this check. Because both `row-base` and `time-base` will be able to meet the incorrect result due to state cleanup. an importation thing we need to do is let use know the function of the `cleanup config`. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---