Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: greghogan <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-3751-flink@git.apache.org>
In-Reply-To: <git-pr-3751-flink@git.apache.org>
Subject: [GitHub] flink pull request #3751: [FLINK-6330] [docs] Add basic Docker, K8s docs
Content-Type: text/plain
Message-Id: <20170510172649.40E98E00A3@git1-us-west.apache.org>
Date: Wed, 10 May 2017 17:26:49 +0000 (UTC)
archived-at: Wed, 10 May 2017 17:26:53 -0000

Github user greghogan commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3751#discussion_r115801773
  
    --- Diff: docs/page/css/syntax.css ---
    @@ -77,3 +77,6 @@
     .highlight .vg { color: #008080 } /* Name.Variable.Global */
     .highlight .vi { color: #008080 } /* Name.Variable.Instance */
     .highlight .il { color: #009999 } /* Literal.Number.Integer.Long */
    +
    +/* Missing YAML styles */
    +.highlight .l-Scalar-Plain { color: #008080 }
    --- End diff --
    
    I think we should merge this PR without this change and look at fixing this in another ticket. There are [other](https://highlightjs.org) highlighters with true YAML support.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---