Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: fhueske <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-3809-flink@git.apache.org>
In-Reply-To: <git-pr-3809-flink@git.apache.org>
Subject: [GitHub] flink pull request #3809: [FLINK-5906] [table] Add support to register UDAGG...
Content-Type: text/plain
Message-Id: <20170503125301.7FD3DE8E71@git1-us-west.apache.org>
Date: Wed,  3 May 2017 12:53:01 +0000 (UTC)
archived-at: Wed, 03 May 2017 12:53:06 -0000

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3809#discussion_r114533693
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/table/DSetUDAGGITCase.scala ---
    @@ -0,0 +1,192 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.api.scala.batch.table
    +
    +import java.math.BigDecimal
    +
    +import org.apache.flink.api.java.{DataSet => JDataSet, ExecutionEnvironment => JavaExecutionEnv}
    +import org.apache.flink.api.java.typeutils.RowTypeInfo
    +import org.apache.flink.api.scala._
    +import org.apache.flink.api.scala.{DataSet, ExecutionEnvironment => ScalaExecutionEnv}
    +import org.apache.flink.table.api.java.utils.UserDefinedAggFunctions.{WeightedAvg, WeightedAvgWithMergeAndReset}
    +import org.apache.flink.table.api.scala.batch.utils.TableProgramsCollectionTestBase
    +import org.apache.flink.table.api.scala.batch.utils.TableProgramsTestBase.TableConfigMode
    +import org.apache.flink.table.api.scala._
    +import org.apache.flink.table.api.{TableEnvironment, Types}
    +import org.apache.flink.table.functions.aggfunctions.CountAggFunction
    +import org.apache.flink.table.utils.TableTestBase
    +import org.apache.flink.test.util.TestBaseUtils
    +import org.apache.flink.types.Row
    +import org.junit._
    +import org.junit.runner.RunWith
    +import org.junit.runners.Parameterized
    +import org.mockito.Mockito.{mock, when}
    +
    +import scala.collection.JavaConverters._
    +
    +/**
    +  * We only test some aggregations until better testing of constructed DataSet
    +  * programs is possible.
    +  */
    +@RunWith(classOf[Parameterized])
    +class DSetUDAGGITCase(configMode: TableConfigMode)
    --- End diff --
    
    Actually, I think we can just extend the existing aggregation tests and add a user-defined aggregation function to some. This way we can avoid many new tests and just adapt some of the existing ones.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---