Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: zentol <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-3778-flink@git.apache.org>
In-Reply-To: <git-pr-3778-flink@git.apache.org>
Subject: [GitHub] flink pull request #3778: [FLINK-5969] Add savepoint backwards compatibility...
Content-Type: text/plain
Message-Id: <20170502122312.74E19DFB91@git1-us-west.apache.org>
Date: Tue,  2 May 2017 12:23:12 +0000 (UTC)
archived-at: Tue, 02 May 2017 12:23:18 -0000

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3778#discussion_r114286782
  
    --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/SavepointMigrationTestBase.java ---
    @@ -208,11 +190,37 @@ protected final void restoreAndExecute(
     		JobSubmissionResult jobSubmissionResult = cluster.submitJobDetached(jobGraph);
     
     		StandaloneClusterClient clusterClient = new StandaloneClusterClient(cluster.configuration());
    +		JobListeningContext jobListeningContext = clusterClient.connectToJob(jobSubmissionResult.getJobID());
     
     		boolean done = false;
     		while (DEADLINE.hasTimeLeft()) {
    +
    +			// try and get a job result, this will fail if the job already failed. Use this
    +			// to get out of this loop
    +			JobID jobId = jobSubmissionResult.getJobID();
    +			FiniteDuration timeout = FiniteDuration.apply(5, TimeUnit.SECONDS);
    +
    +			try {
    +
    +				Future<Object> future = Patterns.ask(clusterClient.getJobManagerGateway().actor(),
    --- End diff --
    
    Could use `ActorGateway#ask()` instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---