flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #3886: [FLINK-6554] [core] Make CompatibilityResult optio...
Date Fri, 12 May 2017 13:11:40 GMT
GitHub user tzulitai opened a pull request:

    https://github.com/apache/flink/pull/3886

    [FLINK-6554] [core] Make CompatibilityResult options more explicitly defined

    Previously, if a serializer determines that state migration needs to be
    performed but could not provide a fallback convert deserializer, it
    would use `CompatibilityResult.requiresMigration(null)`.
    
    This commit makes this option more explicit by having a
    `CompatibilityResult.requiresMigration()` option that takes no parameters.
    This should improve how the user perceives the API without having to rely on
    the Javadoc that it is allowed to have no fallback convert deserializer.
    
    Consequently, when using `CompatibilityResult.requiresMigration(TypeDeserializer)`, the
provided argument cannot be null.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tzulitai/flink FLINK-6554

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3886.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3886
    
----
commit 444329f10f7272ad9964088720c3a8ffb67d30ca
Author: Tzu-Li (Gordon) Tai <tzulitai@apache.org>
Date:   2017-05-12T13:00:51Z

    [FLINK-6554] [core] Make CompatibilityResult options more explicitly defined
    
    Previously, if a serializer determines that state migration needs to be
    performed but could not provide a fallback convert deserializer, it
    would use CompatibilityResult.requiresMigration(null).
    
    This commit makes this option more explicit by having a
    CompatibilityResult.requiresMigration() option that takes no parameters.
    This improves how the user perceives the API without having to rely on
    the Javadoc that it is allowed to have no fallback convert deserializer.
    
    Consequently, when using
    CompatibilityResult.requiresMigration(TypeDeserializer), the provided
    argument cannot be null.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message