flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6711) Activate strict checkstyle for flink-connectors
Date Fri, 26 May 2017 16:27:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026471#comment-16026471
] 

ASF GitHub Bot commented on FLINK-6711:
---------------------------------------

Github user greghogan commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3992#discussion_r118739552
  
    --- Diff: flink-connectors/flink-avro/src/main/java/org/apache/flink/api/avro/FSDataInputStreamWrapper.java
---
    @@ -16,20 +16,19 @@
      * limitations under the License.
      */
     
    -
     package org.apache.flink.api.avro;
     
    -import java.io.Closeable;
    -import java.io.IOException;
    +import org.apache.flink.core.fs.FSDataInputStream;
     
     import org.apache.avro.file.SeekableInput;
    -import org.apache.flink.core.fs.FSDataInputStream;
     
    +import java.io.Closeable;
    +import java.io.IOException;
     
     /**
    - * Code copy pasted from org.apache.avro.mapred.FSInput (which is Apache licensed as
well)
    - * 
    - * The wrapper keeps track of the position in the data stream.
    + * Code copy pasted from org.apache.avro.mapred.FSInput (which is Apache licensed as
well.
    --- End diff --
    
    Lost the closing parenthesis.


> Activate strict checkstyle for flink-connectors
> -----------------------------------------------
>
>                 Key: FLINK-6711
>                 URL: https://issues.apache.org/jira/browse/FLINK-6711
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Batch Connectors and Input/Output Formats, Streaming Connectors
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message