flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6701) Activate strict checkstyle for flink-yarn
Date Fri, 26 May 2017 15:21:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026395#comment-16026395
] 

ASF GitHub Bot commented on FLINK-6701:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3990#discussion_r118726140
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
    @@ -37,75 +37,74 @@
     import org.apache.flink.runtime.resourcemanager.slotmanager.SlotManager;
     import org.apache.flink.runtime.rpc.FatalErrorHandler;
     import org.apache.flink.runtime.rpc.RpcService;
    +import org.apache.flink.util.ExceptionUtils;
    +
     import org.apache.hadoop.yarn.api.ApplicationConstants;
    -import org.apache.hadoop.yarn.api.records.FinalApplicationStatus;
    -import org.apache.hadoop.yarn.api.records.Priority;
    -import org.apache.hadoop.yarn.api.records.Resource;
    -import org.apache.hadoop.yarn.api.records.ContainerStatus;
     import org.apache.hadoop.yarn.api.records.Container;
     import org.apache.hadoop.yarn.api.records.ContainerLaunchContext;
    +import org.apache.hadoop.yarn.api.records.ContainerStatus;
    +import org.apache.hadoop.yarn.api.records.FinalApplicationStatus;
     import org.apache.hadoop.yarn.api.records.NodeReport;
    +import org.apache.hadoop.yarn.api.records.Priority;
    +import org.apache.hadoop.yarn.api.records.Resource;
     import org.apache.hadoop.yarn.client.api.AMRMClient;
     import org.apache.hadoop.yarn.client.api.NMClient;
     import org.apache.hadoop.yarn.client.api.async.AMRMClientAsync;
     import org.apache.hadoop.yarn.conf.YarnConfiguration;
    -import org.slf4j.Logger;
    -import org.slf4j.LoggerFactory;
    -import scala.concurrent.duration.FiniteDuration;
    -import org.apache.flink.util.ExceptionUtils;
     
    -import java.util.Map;
     import java.util.HashMap;
     import java.util.List;
    +import java.util.Map;
     import java.util.concurrent.TimeUnit;
     
    +import scala.concurrent.duration.FiniteDuration;
    +
     /**
      * The yarn implementation of the resource manager. Used when the system is started
      * via the resource framework YARN.
      */
     public class YarnResourceManager extends ResourceManager<ResourceID> implements
AMRMClientAsync.CallbackHandler {
    -	protected final Logger LOG = LoggerFactory.getLogger(getClass());
    --- End diff --
    
    Yes. They both call `getClass()` and thus should look the same from the outside.


> Activate strict checkstyle for flink-yarn
> -----------------------------------------
>
>                 Key: FLINK-6701
>                 URL: https://issues.apache.org/jira/browse/FLINK-6701
>             Project: Flink
>          Issue Type: Sub-task
>          Components: YARN
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message