flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chesnay Schepler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6698) Activate strict checkstyle
Date Fri, 26 May 2017 08:40:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025995#comment-16025995

Chesnay Schepler commented on FLINK-6698:

I may have undersold how many violations we can resolve with these with "a couple thousand".
Here are some numbers for violation types in flink-runtime:

Imports: 1.408
Multiple empty lines: 459
Package line: 80

And here's kicker, tabs on empty lines: *7961*

In total, in ~5 minutes we can kill of 10k violations in flink-runtime, without touching a
single line of functional code.

So yeah, more like we can shave of a couple *ten* thousand.violations with this approach.

> Activate strict checkstyle
> --------------------------
>                 Key: FLINK-6698
>                 URL: https://issues.apache.org/jira/browse/FLINK-6698
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Chesnay Schepler
> Umbrella issue for introducing the strict checkstyle, to keep track of which modules
are already covered.

This message was sent by Atlassian JIRA

View raw message