flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6659) RocksDBMergeIteratorTest, SavepointITCase leave temporary directories behind
Date Mon, 22 May 2017 15:07:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019677#comment-16019677
] 

ASF GitHub Bot commented on FLINK-6659:
---------------------------------------

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/3962

    [FLINK-6659] fix (some) unit tests leaving temporary data behind

    Both, `RocksDBMergeIteratorTest` as well as `SavepointITCase` were using `CommonTestUtils.createTempDirectory()`
to create a temporary directory and never deleted it after the test finishes. This PR replaces
this usage by a JUnit `@Rule` instead.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-6659

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3962.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3962
    
----
commit 79cf9958a2325359c04fa2050264a8c1a3525d13
Author: Nico Kruber <nico@data-artisans.com>
Date:   2017-05-22T14:47:35Z

    [FLINK-6659] fix RocksDBMergeIteratorTest leaving temporary data behind
    
    -> use a JUnit '@Rule' that does the cleanup

commit 77fec6c6a8c771622c89590661bb005ffa3f5488
Author: Nico Kruber <nico@data-artisans.com>
Date:   2017-05-22T14:55:39Z

    [FLINK-6659] fix SavepointITCase leaving temporary data behind
    
    -> use a JUnit '@Rule' that does the cleanup

----


> RocksDBMergeIteratorTest, SavepointITCase leave temporary directories behind
> ----------------------------------------------------------------------------
>
>                 Key: FLINK-6659
>                 URL: https://issues.apache.org/jira/browse/FLINK-6659
>             Project: Flink
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.2.0, 1.3.0, 1.2.1, 1.2.2
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>
> {{RocksDBMergeIteratorTest}} uses a newly created temporary directory (via {{CommonTestUtils.createTempDirectory()}})
for its RocksDB instance but does not delete is when finished. We should better replace this
pattern with a proper {{@Rule}}-based approach



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message