flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6617) Improve JAVA and SCALA logical plans consistent test
Date Tue, 23 May 2017 08:35:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020811#comment-16020811
] 

ASF GitHub Bot commented on FLINK-6617:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3943#discussion_r117928792
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/validation/GroupWindowAggregationsTest.scala
---
    @@ -16,19 +16,19 @@
      * limitations under the License.
      */
     
    -package org.apache.flink.table.api.scala.stream.table
    +package org.apache.flink.table.api.scala.stream.table.validation
    --- End diff --
    
    I think tests in `validation` packages should all test for a `ValidationException`. Can
you split this class?


> Improve JAVA and SCALA logical plans consistent test
> ----------------------------------------------------
>
>                 Key: FLINK-6617
>                 URL: https://issues.apache.org/jira/browse/FLINK-6617
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>    Affects Versions: 1.3.0
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>
> Currently,we need some `StringExpression` test,for all JAVA and SCALA API.
> Such as:`GroupAggregations`,`GroupWindowAggregaton`(Session,Tumble),`Calc` etc.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message