flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6570) QueryableStateClient constructor in documentation doesn't match actual signature
Date Thu, 18 May 2017 07:52:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015372#comment-16015372
] 

ASF GitHub Bot commented on FLINK-6570:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3926#discussion_r117180703
  
    --- Diff: docs/dev/stream/queryable_state.md ---
    @@ -208,10 +208,16 @@ Once used in a job, you can retrieve the job ID and then query any
key's current
     
     {% highlight java %}
     final Configuration config = new Configuration();
    -config.setString(ConfigConstants.JOB_MANAGER_IPC_ADDRESS_KEY, queryAddress);
    -config.setInteger(ConfigConstants.JOB_MANAGER_IPC_PORT_KEY, queryPort);
    +config.setString(JobManagerOptions.ADDRESS, queryAddress);
    +config.setInteger(JobManagerOptions.PORT, queryPort);
     
    -QueryableStateClient client = new QueryableStateClient(config);
    +final HighAvailabilityServices highAvailabilityServices =
    +      HighAvailabilityServicesUtils.createHighAvailabilityServices(
    +           config,
    +           TestingUtils.defaultExecutor(),
    +           HighAvailabilityServicesUtils.AddressResolution.NO_ADDRESS_RESOLUTION);
    --- End diff --
    
    Better to do `TRY_ADDRESS_RESOLUTION` here so that we fail fast in case the JM is not
reachable from the node we are currently running on.


> QueryableStateClient constructor in documentation doesn't match actual signature
> --------------------------------------------------------------------------------
>
>                 Key: FLINK-6570
>                 URL: https://issues.apache.org/jira/browse/FLINK-6570
>             Project: Flink
>          Issue Type: Bug
>          Components: Documentation, Queryable State
>            Reporter: Robert Metzger
>
> The queryable state documentation states to use the following ctor
> {code}
> QueryableStateClient client = new QueryableStateClient(config);
> {code}
> However, this ctor doesn't exist anymore (since 1.3)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message