flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6513) various typos and grammatical flaws
Date Tue, 09 May 2017 17:07:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003063#comment-16003063
] 

ASF GitHub Bot commented on FLINK-6513:
---------------------------------------

Github user greghogan commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3858#discussion_r115543214
  
    --- Diff: docs/dev/best_practices.md ---
    @@ -284,30 +284,30 @@ Change your projects `pom.xml` file like this:
     
     The following changes were done in the `<dependencies>` section:
     
    - * Exclude all `log4j` dependencies from all Flink dependencies: This causes Maven to
ignore Flink's transitive dependencies to log4j.
    - * Exclude the `slf4j-log4j12` artifact from Flink's dependencies: Since we are going
to use the slf4j to logback binding, we have to remove the slf4j to log4j binding.
    + * Exclude all `log4j` dependencies from all Flink dependencies: this causes Maven to
ignore Flink's transitive dependencies to log4j.
    + * Exclude the `slf4j-log4j12` artifact from Flink's dependencies: since we are going
to use the slf4j to logback binding, we have to remove the slf4j to log4j binding.
      * Add the Logback dependencies: `logback-core` and `logback-classic`
    - * Add dependencies for `log4j-over-slf4j`. `log4j-over-slf4j` is a tool which allows
legacy applications which are directly using the Log4j APIs to use the Slf4j interface. Flink
depends on Hadoop which is directly using Log4j for logging. Therefore, we need to redirect
all logger calls from Log4j to Slf4j which is in turn logging to Logback.
    + * Add dependencies for `log4j-over-slf4j`. `log4j-over-slf4j` is a tool which allows
legacy applications which are directly using the Log4j APIs to use the Slf4j interface. Flink
depends on Hadoop which is directly using Log4j for logging. Therefore we need to redirect
all logger calls from Log4j to Slf4j which is in turn logging to Logback.
    --- End diff --
    
    Why remove the comma?


> various typos and grammatical flaws
> -----------------------------------
>
>                 Key: FLINK-6513
>                 URL: https://issues.apache.org/jira/browse/FLINK-6513
>             Project: Flink
>          Issue Type: Improvement
>          Components: Documentation
>    Affects Versions: 1.3.0
>            Reporter: David Anderson
>
> I want to propose small changes to several pages to fix some typos and grammatical flaws.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message