flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6495) Migrate Akka configuration options
Date Fri, 19 May 2017 09:45:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017138#comment-16017138
] 

ASF GitHub Bot commented on FLINK-6495:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3935#discussion_r117441386
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobAttachmentClientActor.java
---
    @@ -114,7 +114,7 @@ else if (JobClientMessages.getRegistrationTimeout().equals(message))
{
     					client.tell(
     						decorateMessage(new Status.Failure(
     							new JobClientActorRegistrationTimeoutException("Registration for Job at the JobManager
" +
    -								"timed out. " +	"You may increase '" + ConfigConstants.AKKA_CLIENT_TIMEOUT +
    +								"timed out. " +	"You may increase '" + AkkaOptions.AKKA_CLIENT_TIMEOUT +
    --- End diff --
    
    `ConfigConstants.AKKA_CLIENT_TIMEOUT` is only the key, so we should only contain the key
of the ConfigOption, i.e `AkkaOptions.AKKA_CLIENT_TIMEOUT.key()`.


> Migrate Akka configuration options
> ----------------------------------
>
>                 Key: FLINK-6495
>                 URL: https://issues.apache.org/jira/browse/FLINK-6495
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination, Network
>            Reporter: Chesnay Schepler
>            Assignee: Fang Yong
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message