flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6492) Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()
Date Mon, 15 May 2017 08:00:15 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010127#comment-16010127
] 

ASF GitHub Bot commented on FLINK-6492:
---------------------------------------

GitHub user huafengw opened a pull request:

    https://github.com/apache/flink/pull/3898

    [FLINK-6492] Fix unclosed DataOutputViewStream usage

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/huafengw/flink fix6492

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3898.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3898
    
----
commit 3a2e981efd5fffd25d551331af5b422a0812e802
Author: huafengw <fvunicorn@gmail.com>
Date:   2017-05-15T07:56:19Z

    [FLINK-6492] Fix unclosed DataOutputViewStream usage

----


> Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()
> -----------------------------------------------------------------------------
>
>                 Key: FLINK-6492
>                 URL: https://issues.apache.org/jira/browse/FLINK-6492
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing
>            Reporter: Ted Yu
>            Priority: Minor
>
> {code}
>    InstantiationUtil.serializeObject(new DataOutputViewStream(out), componentClass);
> {code}
> DataOutputViewStream instance should be closed upon return.
> TupleSerializerConfigSnapshot has similar issue.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message