flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6482) Add nested serializers into configuration snapshots of composite serializers
Date Mon, 22 May 2017 09:10:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019329#comment-16019329
] 

ASF GitHub Bot commented on FLINK-6482:
---------------------------------------

Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3937#discussion_r117696993
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeTypeSerializerConfigSnapshot.java
---
    @@ -73,13 +91,11 @@ public boolean equals(Object obj) {
     		}
     
     		return (obj.getClass().equals(getClass()))
    -				&& Arrays.equals(
    -					nestedSerializerConfigSnapshots,
    -					((CompositeTypeSerializerConfigSnapshot) obj).getNestedSerializerConfigSnapshots());
    +				&& nestedSerializersWithConfigs.equals(((CompositeTypeSerializerConfigSnapshot)
obj).getNestedSerializersAndConfigs());
    --- End diff --
    
    This is not doing a deep equals on the array.


> Add nested serializers into configuration snapshots of composite serializers
> ----------------------------------------------------------------------------
>
>                 Key: FLINK-6482
>                 URL: https://issues.apache.org/jira/browse/FLINK-6482
>             Project: Flink
>          Issue Type: Improvement
>          Components: State Backends, Checkpointing, Type Serialization System
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Tzu-Li (Gordon) Tai
>            Priority: Blocker
>             Fix For: 1.3.0
>
>
> Currently, the composite serializers' configuration snapshots only wrap the config snapshots
of nested serializers.
> We should also consider adding serialization of the nested serializers into the config
snapshot, so that in the case where only some nested serializer cannot be loaded (class missing
/ implementation changed), we can also provide a path for serializer upgrades.
> This applies for all composite serializers that have nested serializers.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message