flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6462) Add requiresOver interface for AggregateFunction
Date Fri, 12 May 2017 12:50:05 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008063#comment-16008063
] 

ASF GitHub Bot commented on FLINK-6462:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3851#discussion_r116211438
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/DataSetAggregateRule.scala
---
    @@ -53,8 +54,17 @@ class DataSetAggregateRule
     
         // check if we have distinct aggregates
         val distinctAggs = agg.getAggCallList.exists(_.isDistinct)
    +    if (distinctAggs) {
    +      throw TableException("DISTINCT aggregates are currently not supported.")
    +    }
    +
    +    // check if we have over aggregates
    +    val overAggs = agg.getAggCallList.exists(_.getAggregation.requiresOver())
    --- End diff --
    
    use `filter` instead of `exists` to extract the functions that require OVER.


> Add requiresOver interface for  AggregateFunction
> -------------------------------------------------
>
>                 Key: FLINK-6462
>                 URL: https://issues.apache.org/jira/browse/FLINK-6462
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>             Fix For: 1.3.0
>
>
> The window function in the standard database only supports the "over" window, such as
`LAG`,` LEAD`, `FIRST_VALUE`,` LAST_VALUE`. These window functions do not apply to `Slide`,`
Tumble`, `Session` window. So when the user-defined AGG need to be clearly defined. In calcite
`SqlAggFunction` will using `requiresOver` to distinguish. 
> In this JIRA. will deal with this feature.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message