flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6439) Unclosed InputStream in OperatorSnapshotUtil#readStateHandle()
Date Thu, 04 May 2017 06:27:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996245#comment-15996245
] 

ASF GitHub Bot commented on FLINK-6439:
---------------------------------------

GitHub user fanyon opened a pull request:

    https://github.com/apache/flink/pull/3819

    [FLINK-6439] Fix close OutputStream && InputStream in OperatorSnapshotUtil

    …tUtil
    
    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fanyon/flink FLINK-6439

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3819.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3819
    
----
commit de723c7eb9ad9b8c8c27d6b884d47faa7d324dfd
Author: mengji.fy <mengji.fy@taobao.com>
Date:   2017-05-04T05:37:01Z

    [FLINK-6439] Fix close OutputStream && InputStream in OperatorSnapshotUtil

----


> Unclosed InputStream in OperatorSnapshotUtil#readStateHandle()
> --------------------------------------------------------------
>
>                 Key: FLINK-6439
>                 URL: https://issues.apache.org/jira/browse/FLINK-6439
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Fang Yong
>            Priority: Minor
>
> {code}
>     FileInputStream in = new FileInputStream(path);
>     DataInputStream dis = new DataInputStream(in);
> {code}
> None of the in / dis is closed upon return from the method.
> In writeStateHandle(), OutputStream should be closed in finally block.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message