flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Fabian Hueske (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6433) Unreachable code in SqlToRelConverter#visitCall()
Date Tue, 02 May 2017 16:24:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993198#comment-15993198
] 

Fabian Hueske commented on FLINK-6433:
--------------------------------------

Thanks for reporting this.

This class was copied from Apache Calcite as a temporary fix until Calcite 1.13 is released
and we updated the dependency.
I think we can leave this class as it is.

> Unreachable code in SqlToRelConverter#visitCall()
> -------------------------------------------------
>
>                 Key: FLINK-6433
>                 URL: https://issues.apache.org/jira/browse/FLINK-6433
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> {code}
>       SqlFunction histogramOp = !ENABLE_HISTOGRAM_AGG
>         ? null
>         : getHistogramOp(aggOp);
>       if (histogramOp != null) {
> {code}
> Since ENABLE_HISTOGRAM_AGG is hardcoded as false, the if block wouldn't be executed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message