flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6426) Update the document of group-window table API&SQL
Date Fri, 12 May 2017 03:19:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007577#comment-16007577

ASF GitHub Bot commented on FLINK-6426:

Github user sunjincheng121 commented on a diff in the pull request:

    --- Diff: docs/dev/table_api.md ---
    @@ -1485,14 +1485,14 @@ Joins, set operations, and non-windowed aggregations are not supported
     {% top %}
    -### Group Windows
    +### Windows
    --- End diff --
    I'd like called them `Windows`. All of the names are `Tumble`,`Slide`,`Session` and `Over`.
It's consistent with the interface of the table API. Because we only have`window(...)` method
in `Table.scala`. although the param of  `window(overWindows: OverWindow*)` and `window(window:
Window)` a little difference. 
     When user using the tableAPI/SQL they only notice that  there are 4 kinds of windows
    They are  `Tumble`, `Slide/Hup`, `Session` and `Over`. We'd better not reflect the concept
of group window. What do you think?

> Update the document of group-window table API&SQL
> -------------------------------------------------
>                 Key: FLINK-6426
>                 URL: https://issues.apache.org/jira/browse/FLINK-6426
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Documentation, Table API & SQL
>    Affects Versions: 1.3.0
>            Reporter: sunjincheng
>            Assignee: sunjincheng
> 1.Correct the method parameter type error in the group-window table API document, change
the document from ` .window([w: Window] as 'w)` to ` .window([w: WindowWithoutAlias] as 'w)`
> 2. For the consistency of tableAPI and SQL, change the description of SQL document from
"Group Windows" to "Windows".

This message was sent by Atlassian JIRA

View raw message