flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6337) Remove the buffer provider from PartitionRequestServerHandler
Date Tue, 02 May 2017 09:55:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15992659#comment-15992659
] 

ASF GitHub Bot commented on FLINK-6337:
---------------------------------------

Github user uce commented on the issue:

    https://github.com/apache/flink/pull/3785
  
    Thanks! Looks good to merge now 👍 I've rebased it and pushed it to Travis here: https://travis-ci.org/uce/flink/builds/227891373
    
    As soon as it succeeds, I'm going to merge this PR.



> Remove the buffer provider from PartitionRequestServerHandler
> -------------------------------------------------------------
>
>                 Key: FLINK-6337
>                 URL: https://issues.apache.org/jira/browse/FLINK-6337
>             Project: Flink
>          Issue Type: Improvement
>          Components: Network
>            Reporter: zhijiang
>            Assignee: zhijiang
>            Priority: Minor
>
> Currently, {{PartitionRequestServerHandler}} will create a {{LocalBufferPool}} when the
channel is registered. The {{LocalBufferPool}} is only used to get segment size for creating
read view in {{SpillableSubpartition}}, and the buffers in the pool will not be used all the
time, so it will waste the buffer resource of global pool.
> We would like to remove the {{LocalBufferPool}} from the {{PartitionRequestServerHandler}},
and the {{LocalBufferPool}} in {{ResultPartition}} can also provide the segment size for creating
sub partition view.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message