flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6330) Improve Docker documentation
Date Wed, 10 May 2017 17:27:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005071#comment-16005071
] 

ASF GitHub Bot commented on FLINK-6330:
---------------------------------------

Github user greghogan commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3751#discussion_r115801773
  
    --- Diff: docs/page/css/syntax.css ---
    @@ -77,3 +77,6 @@
     .highlight .vg { color: #008080 } /* Name.Variable.Global */
     .highlight .vi { color: #008080 } /* Name.Variable.Instance */
     .highlight .il { color: #009999 } /* Literal.Number.Integer.Long */
    +
    +/* Missing YAML styles */
    +.highlight .l-Scalar-Plain { color: #008080 }
    --- End diff --
    
    I think we should merge this PR without this change and look at fixing this in another
ticket. There are [other](https://highlightjs.org) highlighters with true YAML support.


> Improve Docker documentation
> ----------------------------
>
>                 Key: FLINK-6330
>                 URL: https://issues.apache.org/jira/browse/FLINK-6330
>             Project: Flink
>          Issue Type: Bug
>          Components: Docker
>    Affects Versions: 1.2.0
>            Reporter: Patrick Lucas
>            Assignee: Patrick Lucas
>             Fix For: 1.2.2
>
>
> The "Docker" page in the docs exists but is blank.
> Add something useful here, including references to the official images that should exist
once 1.2.1 is released, and add a brief "Kubernetes" page as well, referencing the [helm chart|https://github.com/docker-flink/examples].




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message