flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6320) Flakey JobManagerHAJobGraphRecoveryITCase
Date Mon, 22 May 2017 16:21:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019760#comment-16019760
] 

ASF GitHub Bot commented on FLINK-6320:
---------------------------------------

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/3966

    [FLINK-6320] fix unit test failing sometimes when deleting a temp dir

    use a JUnit rule with a `TemporaryFolder` instead which should fix this (alternatively,
catching the exception may have fixed this symptom but using a temporary folder should be
even more save in case a real concurrency issue was present)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-6320

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3966.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3966
    
----
commit 5b440c4084076c8086d888c4d5439c2e5f65bdf6
Author: Nico Kruber <nico@data-artisans.com>
Date:   2017-05-22T14:31:08Z

    [FLINK-6320] fix unit test failing sometimes when deleting a temp directory

----


> Flakey JobManagerHAJobGraphRecoveryITCase
> -----------------------------------------
>
>                 Key: FLINK-6320
>                 URL: https://issues.apache.org/jira/browse/FLINK-6320
>             Project: Flink
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.3.0
>            Reporter: Nico Kruber
>              Labels: test-stability
>
> it looks as if there is a race condition in the cleanup of {{JobManagerHAJobGraphRecoveryITCase}}.
> {code}
> Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 50.271 sec <<<
FAILURE! - in org.apache.flink.test.recovery.JobManagerHAJobGraphRecoveryITCase
> testJobPersistencyWhenJobManagerShutdown(org.apache.flink.test.recovery.JobManagerHAJobGraphRecoveryITCase)
 Time elapsed: 0.129 sec  <<< ERROR!
> java.io.FileNotFoundException: File does not exist: /tmp/9b63934b-789d-428c-aa9e-47d5d8fa1e32/recovery/submittedJobGraphf763d61fba47
> 	at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2275)
> 	at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1653)
> 	at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1535)
> 	at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2270)
> 	at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1653)
> 	at org.apache.flink.test.recovery.JobManagerHAJobGraphRecoveryITCase.cleanUp(JobManagerHAJobGraphRecoveryITCase.java:112)
> {code}
> Full log: https://s3.amazonaws.com/archive.travis-ci.org/jobs/223124016/log.txt
> Maybe a rule-based temporary directory is a better solution:
> {code:java}
> 	@Rule
> 	public TemporaryFolder tempFolder = new TemporaryFolder();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message