flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6284) Incorrect sorting of completed checkpoints in ZooKeeperCompletedCheckpointStore
Date Fri, 12 May 2017 08:22:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007787#comment-16007787

ASF GitHub Bot commented on FLINK-6284:

GitHub user ramkrish86 opened a pull request:


    FLINK-6284 Incorrect sorting of completed checkpoints in ZooKeeperCompletedCheckpointStore

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    Making use of the Zookeeper's getChildren() API directly so that it just creates a list
in the sequence order. If we go with the ZKPaths API then we need to do some sorting by converting
the List<STring> to List<Long>.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ramkrish86/flink FLINK-6284

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3881
commit 33bf37a2d706af6c8eb6cbe9d58aa3ac9d1f03e0
Author: Ramkrishna <ramkrishna.s.vasudevan@intel.com>
Date:   2017-05-12T08:18:16Z

    FLINK-6284 Incorrect sorting of completed checkpoints in


> Incorrect sorting of completed checkpoints in ZooKeeperCompletedCheckpointStore
> -------------------------------------------------------------------------------
>                 Key: FLINK-6284
>                 URL: https://issues.apache.org/jira/browse/FLINK-6284
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing
>            Reporter: Xiaogang Shi
>            Priority: Blocker
>             Fix For: 1.3.0
> Now all completed checkpoints are sorted in their paths when they are recovered in {{ZooKeeperCompletedCheckpointStore}}
. In the cases where the latest checkpoint's id is not the largest in lexical order (e.g.,
"100" is smaller than "99" in lexical order), Flink will not recover from the latest completed
> The problem can be easily observed by setting the checkpoint ids in {{ZooKeeperCompletedCheckpointStoreITCase#testRecover()}}
to be 99, 100 and 101. 
> To fix the problem, we should explicitly sort found checkpoints in their checkpoint ids,
without the usage of {{ZooKeeperStateHandleStore#getAllSortedByName()}}

This message was sent by Atlassian JIRA

View raw message