flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6058) Don't read DEFAULT_PARALLELISM from GlobalConfiguration
Date Tue, 16 May 2017 10:43:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012126#comment-16012126
] 

ASF GitHub Bot commented on FLINK-6058:
---------------------------------------

GitHub user zjureel opened a pull request:

    https://github.com/apache/flink/pull/3921

    [FLINK-6058] fix read DEFAULT_PARALLELISM from ContextEnvironment

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjureel/flink FLINK-6058

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3921.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3921
    
----
commit 808f252f64ac96569a16ba3d0a020ad978983513
Author: zjureel <zjureel@gmail.com>
Date:   2017-05-16T07:58:10Z

    fix read DEFAULT_PARALLELISM from ContextEnvironment

----


> Don't read DEFAULT_PARALLELISM from GlobalConfiguration
> -------------------------------------------------------
>
>                 Key: FLINK-6058
>                 URL: https://issues.apache.org/jira/browse/FLINK-6058
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>            Reporter: Aljoscha Krettek
>            Assignee: Fang Yong
>
> In the constructor of {{StreamContextEnvironment}} we read the {{DEFAULT_PARALLELISM}}
from the {{GlobalConfiguration}}. This assumes that the environment variables are correctly
set and can lead to problems. We should read the default parallelism in the client and set
it in the {{ContextEnvironment}} that it creates. This can then be read by the {{StreamContextEnvironment}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message