flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5906) Add support to register UDAGG in Table and SQL API
Date Wed, 03 May 2017 15:44:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995101#comment-15995101
] 

ASF GitHub Bot commented on FLINK-5906:
---------------------------------------

Github user shaoxuan-wang commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3809#discussion_r114579772
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/table/DSetUDAGGITCase.scala
---
    @@ -0,0 +1,192 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.api.scala.batch.table
    +
    +import java.math.BigDecimal
    +
    +import org.apache.flink.api.java.{DataSet => JDataSet, ExecutionEnvironment =>
JavaExecutionEnv}
    +import org.apache.flink.api.java.typeutils.RowTypeInfo
    +import org.apache.flink.api.scala._
    +import org.apache.flink.api.scala.{DataSet, ExecutionEnvironment => ScalaExecutionEnv}
    +import org.apache.flink.table.api.java.utils.UserDefinedAggFunctions.{WeightedAvg, WeightedAvgWithMergeAndReset}
    +import org.apache.flink.table.api.scala.batch.utils.TableProgramsCollectionTestBase
    +import org.apache.flink.table.api.scala.batch.utils.TableProgramsTestBase.TableConfigMode
    +import org.apache.flink.table.api.scala._
    +import org.apache.flink.table.api.{TableEnvironment, Types}
    +import org.apache.flink.table.functions.aggfunctions.CountAggFunction
    +import org.apache.flink.table.utils.TableTestBase
    +import org.apache.flink.test.util.TestBaseUtils
    +import org.apache.flink.types.Row
    +import org.junit._
    +import org.junit.runner.RunWith
    +import org.junit.runners.Parameterized
    +import org.mockito.Mockito.{mock, when}
    +
    +import scala.collection.JavaConverters._
    +
    +/**
    +  * We only test some aggregations until better testing of constructed DataSet
    +  * programs is possible.
    +  */
    +@RunWith(classOf[Parameterized])
    +class DSetUDAGGITCase(configMode: TableConfigMode)
    --- End diff --
    
    Sounds good to me. I did not have the UDAGG design across all different aggregation tests,
as I feel the current agg tests are a little mess up. It always takes me a while to find the
right test cases among all different test files. I put UDAGG test cases into one file which
helps me to easily understand what kinds of tests have been covered. I think we need to think
about how to reorganize our agg test structure. Considering the short time to freeze feature,
let us keep the current structure (I will split the UDAGG into all different agg test files)
and massage the tests later.


> Add support to register UDAGG in Table and SQL API
> --------------------------------------------------
>
>                 Key: FLINK-5906
>                 URL: https://issues.apache.org/jira/browse/FLINK-5906
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Fabian Hueske
>            Assignee: Shaoxuan Wang
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message