flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5884) Integrate time indicators for Table API & SQL
Date Fri, 05 May 2017 01:25:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997696#comment-15997696
] 

ASF GitHub Bot commented on FLINK-5884:
---------------------------------------

Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3808#discussion_r114920160
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala
---
    @@ -194,7 +194,30 @@ abstract class BatchTableEnvironment(
       protected def registerDataSetInternal[T](
           name: String, dataSet: DataSet[T], fields: Array[Expression]): Unit = {
     
    -    val (fieldNames, fieldIndexes) = getFieldInfo[T](dataSet.getType, fields)
    +    val (fieldNames, fieldIndexes) = getFieldInfo[T](
    +      dataSet.getType,
    +      fields,
    +      ignoreTimeAttributes = true)
    +
    +    // validate and extract time attributes
    +    val (rowtime, proctime) = validateAndExtractTimeAttributes(fieldNames, fieldIndexes,
fields)
    +
    +    // don't allow proctime on batch
    +    proctime match {
    --- End diff --
    
    In fact, In batch mode we only support `event-time`, And the the column that represents
the `rowtime` is not an indicators but a real exist field. We only care about the data type
of the field,So IMO. we can not using both `.proctime` and `.rowtime` in batch mode.


> Integrate time indicators for Table API & SQL
> ---------------------------------------------
>
>                 Key: FLINK-5884
>                 URL: https://issues.apache.org/jira/browse/FLINK-5884
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Blocker
>             Fix For: 1.3.0
>
>
> We already discussed the need for a proper integration of time indicators (event-time
or processing-time) for both the Table API & SQL on the ML:
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Table-API-SQL-indicators-for-event-and-processing-time-tp15927.html
> This issue will track the progress. I will work on a design document how we can solve
this issue.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message